Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPI breaking changes CI tests #6612

Merged
merged 6 commits into from
Sep 27, 2023

Conversation

Jonathan-Rosenberg
Copy link
Contributor

Closes #6425

Change Description

The PR includes a new workflow that tests for breaking API changes in the swagger YAMLs.

@Jonathan-Rosenberg Jonathan-Rosenberg added the exclude-changelog PR description should not be included in next release changelog label Sep 18, 2023
@Jonathan-Rosenberg Jonathan-Rosenberg changed the title add openapi yaml breaking changes tests to the CI OpenAPI breaking changes CI tests Sep 26, 2023
@Jonathan-Rosenberg Jonathan-Rosenberg self-assigned this Sep 26, 2023
@Jonathan-Rosenberg Jonathan-Rosenberg added the v1.0.0-blocker Issues that should be closed before going out with v1.0.0 label Sep 26, 2023
@Jonathan-Rosenberg Jonathan-Rosenberg marked this pull request as ready for review September 26, 2023 09:48
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Understood F2F that it failed and succeeded, and I can see both cases on the Action page -- hurrah.

Thanks: This should be a required check soon after we pull it, of course :-)

@Jonathan-Rosenberg Jonathan-Rosenberg merged commit ed8ace8 into master Sep 27, 2023
37 checks passed
@Jonathan-Rosenberg Jonathan-Rosenberg deleted the feature/swagger-compatibility-tests branch September 27, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-changelog PR description should not be included in next release changelog v1.0.0-blocker Issues that should be closed before going out with v1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.0] Forwards-compatible Python clients
2 participants