Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove recursive flag from lakectl fs Upload and Download #6681

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Remove recursive flag from lakectl fs Upload and Download #6681

merged 1 commit into from
Oct 3, 2023

Conversation

idanovo
Copy link
Contributor

@idanovo idanovo commented Oct 2, 2023

No description provided.

@idanovo idanovo added area/lakectl Issues related to lakeFS' command line interface (lakectl) include-changelog PR description should be included in next release changelog labels Oct 2, 2023
@idanovo idanovo requested a review from N-o-Z October 2, 2023 13:06
@idanovo idanovo self-assigned this Oct 2, 2023
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

1 similar comment
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

N-o-Z
N-o-Z reviewed Oct 2, 2023
View reviewed changes
Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to wait with that as we are about to release a fix to a version which originally deprecated this flag

@idanovo idanovo added the minor-change Used for PRs that don't require issue attached label Oct 2, 2023
N-o-Z
N-o-Z approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@idanovo idanovo merged commit e164327 into master Oct 3, 2023
35 of 38 checks passed
@idanovo idanovo deleted the remove-recursive-flag-lakectl-fs branch October 3, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N-o-Z N-o-Z N-o-Z approved these changes

Assignees

@idanovo idanovo

Labels
area/lakectl Issues related to lakeFS' command line interface (lakectl) include-changelog PR description should be included in next release changelog minor-change Used for PRs that don't require issue attached
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@idanovo @N-o-Z