CosmosDB: Add throughput configuration #6693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-o-Z
added
include-changelog
|
♻️ PR Preview b25e45f has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
nopcoder
suggested changes
Oct 4, 2023
docs/reference/configuration.md
Outdated
| @@ -65,6 +65,8 @@ This reference uses `.` to denote the nesting of values. | |||
| + `database.cosmosdb.endpoint` `(string : "")` - CosmosDB account endpoint, e.g. `https://<account>.documents.azure.com/`. | |||
| + `database.cosmosdb.database` `(string : "")` - CosmosDB database name. | |||
| + `database.cosmosdb.container` `(string : "")` - CosmosDB container name. | |||
| + `database.cosmosdb.throughput` `(uint : 400)` - The container's RU/s. | |||
There was a problem hiding this comment.
- how do we control if we lick to configure throughput?
- prefer to let the user configure the value if choose to use cosmos
- can we keep the type to int - I assume that invalid values will fail to configure the feature
- include "CosmosDB..." as part of the parameter description
There was a problem hiding this comment.
- Throughput is always configured whether autoscaling or manual mode
- This is anyway the default for cosmosDB if no configuration provided - using the default in our configuration makes this fact accessible to the user
- Done
- Going the other way and removing CosmosDB from all parameter description (redundant + aligning with DyanmoDB description)
nopcoder
suggested changes
Oct 4, 2023
pkg/config/config.go
Outdated
| Endpoint string `mapstructure:"endpoint"` | ||
| Database string `mapstructure:"database"` | ||
| Container string `mapstructure:"container"` | ||
| Throughput *int32 `mapstructure:"throughput"` |
There was a problem hiding this comment.
can you use int without setting any default we can assume 0 as non value.
nopcoder
approved these changes
Oct 4, 2023
pkg/kv/cosmosdb/store.go
Outdated
| var opts *azcosmos.CreateContainerOptions | ||
| if params.Throughput > 0 { | ||
| var throughputProperties azcosmos.ThroughputProperties | ||
| tp := params.Throughput |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6692
Change Description
Background
Add configuration to control CosmosDB container throughput RU/s and autoscaling mode
Testing Details
Tested manually
Breaking Change?
No