Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Following API changes lakeFSFS only compatible with lakeFS >= 0.108.0 #6725

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

arielshaqed
Copy link
Contributor

@arielshaqed arielshaqed commented Oct 8, 2023

No need to test lakeFSFS with previous server versions - it
fails
, and this is fine.

Include in changelog!

This is for when we release lakeFSFS - a separate release process with separate versioning.

Recommended message in changelog:

LakeFSFileSystem is now compatible only with lakeFS versions >= 0.108.0.

Recommended also to announce this on public Slack, of course.

@github-actions
Copy link

github-actions bot commented Oct 8, 2023

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@arielshaqed arielshaqed added area/API Improvements or additions to the API java Pull requests that update Java code include-changelog PR description should be included in next release changelog v1.0.0-blocker Issues that should be closed before going out with v1.0.0 minor-change Used for PRs that don't require issue attached area/client/hadoopfs labels Oct 8, 2023
@arielshaqed
Copy link
Contributor Author

Thanks! Pulling, let's see it pass :-)

@arielshaqed arielshaqed merged commit f29786a into master Oct 8, 2023
@arielshaqed arielshaqed deleted the chore/lakefsfs-compatibility-post-0.108.0 branch October 8, 2023 10:14
@N-o-Z
Copy link
Member

N-o-Z commented Oct 8, 2023

@arielshaqed we should communicate to the users somehow if compatibility was broken. This is the reason the workflow was created and this is our guarantee for client - server version compatibility

@arielshaqed
Copy link
Contributor Author

@arielshaqed we should communicate to the users somehow if compatibility was broken. This is the reason the workflow was created and this is our guarantee for client - server version compatibility

include-changelog for this reason. Adding a recommended warning to the description.

@arielshaqed arielshaqed mentioned this pull request Oct 8, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API Improvements or additions to the API area/client/hadoopfs include-changelog PR description should be included in next release changelog java Pull requests that update Java code minor-change Used for PRs that don't require issue attached v1.0.0-blocker Issues that should be closed before going out with v1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants