use unlogged table for cataloger diff results #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielshaqed
requested changes
Oct 1, 2020
arielshaqed
requested changes
Oct 1, 2020
| // contextWithDiffResultsDispose generate diff results id used for temporary table name | ||
| func contextWithDiffResultsDispose(ctx context.Context, tx sq.Execer) (context.Context, context.CancelFunc) { | ||
| id := xid.New().String() | ||
| // withDiffResultsContext generate diff results id used for temporary table name |
There was a problem hiding this comment.
Suggested change
| // withDiffResultsContext generate diff results id used for temporary table name | |
| // withDiffResultsContext generates diff results id used for temporary table name |
| id := xid.New().String() | ||
| // withDiffResultsContext generate diff results id used for temporary table name | ||
| func (c *cataloger) withDiffResultsContext(ctx context.Context) (context.Context, context.CancelFunc) { | ||
| id := strings.ReplaceAll(uuid.New().String(), "-", "") |
There was a problem hiding this comment.
Actually, this produces a valid table name only 37.5% of the time, when the first hex digit is a-f. You might prepend "diff_table_" to this string.
Or just use nanoid, which is designed to produce useful unescaped names :-/
There was a problem hiding this comment.
yeah, it already gets a prefix.
arielshaqed
approved these changes
Oct 1, 2020
| id := xid.New().String() | ||
| // withDiffResultsContext generate diff results id used for temporary table name | ||
| func (c *cataloger) withDiffResultsContext(ctx context.Context) (context.Context, context.CancelFunc) { | ||
| id := strings.ReplaceAll(uuid.New().String(), "-", "") |
There was a problem hiding this comment.
yeah, it already gets a prefix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.