Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align api/swagger version to v1.0.0 #6893

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Align api/swagger version to v1.0.0 #6893

merged 1 commit into from
Oct 31, 2023

Conversation

nopcoder
Copy link
Contributor

Swagger API version - internal version update to v1.0.0

@nopcoder nopcoder self-assigned this Oct 26, 2023
@github-actions
Copy link

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@nopcoder nopcoder added area/API Improvements or additions to the API exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached and removed minor-change Used for PRs that don't require issue attached labels Oct 26, 2023
@nopcoder nopcoder marked this pull request as ready for review October 26, 2023 21:58
@nopcoder nopcoder requested a review from arielshaqed October 30, 2023 10:53
arielshaqed
arielshaqed approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch. At least this guarantees that versioning of API and code will be different.

Please post on #dev about having to update this version number from now on!

@nopcoder nopcoder merged commit 3c0f7b9 into master Oct 31, 2023
37 of 40 checks passed
@nopcoder nopcoder deleted the chore/update-swagger-v1 branch October 31, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielshaqed arielshaqed arielshaqed approved these changes

Assignees

@nopcoder nopcoder

Labels
area/API Improvements or additions to the API exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nopcoder @arielshaqed