Long running dump and restore capability #6975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nopcoder
added
area/API
|
♻️ PR Preview 86ad171 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
johnnyaug
approved these changes
Nov 12, 2023
api/swagger.yml
Outdated
| tags: | ||
| - repositories | ||
| operationId: restoreStatus | ||
| summary: Restore repository (tags, commits, branches) from object store |
There was a problem hiding this comment.
Suggested change
| summary: Restore repository (tags, commits, branches) from object store | |
| summary: Status of a restore request |
?
There was a problem hiding this comment.
think I updated and override the doc version
pkg/api/controller_test.go
Outdated
| // pullRestoreStatus polls the restore status endpoint until the restore is complete or times out. | ||
| // test will fail in case of error. | ||
| // will return nil in case of timeout. | ||
| func pullRestoreStatus(t *testing.T, clt apigen.ClientWithResponsesInterface, repo string, taskID string) *apigen.RepositoryRestoreStatus { |
There was a problem hiding this comment.
Suggested change
| func pullRestoreStatus(t *testing.T, clt apigen.ClientWithResponsesInterface, repo string, taskID string) *apigen.RepositoryRestoreStatus { | |
| func pollRestoreStatus(t *testing.T, clt apigen.ClientWithResponsesInterface, repo string, taskID string) *apigen.RepositoryRestoreStatus { |
(also in other places)
There was a problem hiding this comment.
There are still occurrences of "pull" instead of "poll".
Co-authored-by: Yoni <yoni.augarten@treeverse.io>
Co-authored-by: Yoni <yoni.augarten@treeverse.io>
Co-authored-by: Yoni <yoni.augarten@treeverse.io>
nopcoder
force-pushed
the
feature/dump-async
branch
from
29f6dc4 to
c64f086
Compare
johnnyaug
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New dump and restore refs API
A new API for dumping and restoring refs. The API allows users to submit requests and then pull the status of the task and the complete information about the request once it is finished.
The new API is used by the
lakectl refs-dumpandlakectl refs-restorecommands.The new API offers a long running operations without the risk of timeout dropping the request.
Close #6527