kv dynamodb check if table exists before we try to create #7056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guy-har
approved these changes
Nov 26, 2023
pkg/kv/dynamodb/store.go
Outdated
Comment on lines
116
to
118
| // Create table if not exists | ||
| success, _ := isTableExist(ctx, svc, params.TableName) |
There was a problem hiding this comment.
Can you please documentation explaining why we need isExist and not satisfied with the response of the create table
nopcoder
added
the
include-changelog
nopcoder
force-pushed
the
fix/kv-open
branch
from
3cbad27 to
ff29a79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a revert of previous behaviour we had for kv Open in lakeFS - checking the table current state before creation.
In order to support running lakeFS in environment without permissions to create, checking before trying to create, will prevent errors.
Close #7059