Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip ensureStorageNamespace when creating a read-only repository #7449

Merged
merged 3 commits into from
Feb 11, 2024
Merged

Skip ensureStorageNamespace when creating a read-only repository #7449

merged 3 commits into from
Feb 11, 2024

Conversation

idanovo
Copy link
Contributor

@idanovo idanovo commented Feb 9, 2024

Closes #7448

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024 •
edited
Loading

🎊 PR Preview 67da2ac has been successfully built and deployed to https://treeverse-lakeFS-preview-pr-7449.surge.sh

🕐 Build time: 0.011s

🤖 By surge-preview

@idanovo idanovo added area/API Improvements or additions to the API new-feature Issues that introduce new feature or capability include-changelog PR description should be included in next release changelog labels Feb 9, 2024
@idanovo idanovo self-assigned this Feb 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024

E2E Test Results - DynamoDB Local - Local Block Adapter

10 passed

@idanovo idanovo changed the title Add an option to skip ensureStorageNamespace when creating a repository Skip ensureStorageNamespace when creating a read-only repository Feb 11, 2024
arielshaqed
arielshaqed approved these changes Feb 11, 2024
View reviewed changes
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer tip: don't show whitespace changes when reviewing this code.
GitHub PR files tab gear menu "diff view" with "Hide whitespace" selected

Thanks, this looks very neat and makes a lot of sense: something else will literally write to this storage namespace!

@idanovo idanovo merged commit 9ef790f into master Feb 11, 2024
37 checks passed
@idanovo idanovo deleted the 7448-create-repository-ignore-dummy-file branch February 11, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielshaqed arielshaqed arielshaqed approved these changes

@guy-har guy-har Awaiting requested review from guy-har

Assignees

@idanovo idanovo

Labels
area/API Improvements or additions to the API include-changelog PR description should be included in next release changelog new-feature Issues that introduce new feature or capability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an option to ignore/override dummy file when creating a lakeFS repository
2 participants
@idanovo @arielshaqed