Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix createDirectoryMarkerIfNotExists #7510

Merged
merged 1 commit into from
Feb 25, 2024
Merged

Fix createDirectoryMarkerIfNotExists #7510

merged 1 commit into from
Feb 25, 2024

Conversation

N-o-Z
Copy link
Member

@N-o-Z N-o-Z commented Feb 25, 2024

Closes #7509

@N-o-Z N-o-Z added include-changelog PR description should be included in next release changelog area/client/hadoopfs labels Feb 25, 2024
@N-o-Z N-o-Z requested review from arielshaqed and a team February 25, 2024 12:02
@N-o-Z N-o-Z self-assigned this Feb 25, 2024
@github-actions GitHub Actions
Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

10 passed

@N-o-Z N-o-Z mentioned this pull request Feb 25, 2024
Closed
itaiad200
itaiad200 requested changes Feb 25, 2024
View reviewed changes
Copy link
Contributor

@itaiad200 itaiad200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the purpose of this change. You still rely on ifNoneMatch("*") since 2 workers may list 0 items and then try to create it at the same time. Why are we bothered by the current implementation?

@N-o-Z
Copy link
Member Author

N-o-Z commented Feb 25, 2024

I don't understand the purpose of this change. You still rely on ifNoneMatch("*") since 2 workers may list 0 items and then try to create it at the same time. Why are we bothered by the current implementation?

The fix insure we do not create a directory marker if the directory is not empty - there's no attempt to solve an issue of multiple writers

@N-o-Z N-o-Z requested a review from itaiad200 February 25, 2024 16:25
@N-o-Z N-o-Z merged commit 9e2452a into master Feb 25, 2024
39 checks passed
@N-o-Z N-o-Z deleted the fix/create-directory-marker-when-not-empty-7509 branch February 25, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itaiad200 itaiad200 itaiad200 approved these changes

@arielshaqed arielshaqed Awaiting requested review from arielshaqed

Assignees

@N-o-Z N-o-Z

Labels
area/client/hadoopfs include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: lakeFSFS creates directory markers even when path is not empty on delete
2 participants
@N-o-Z @itaiad200