Integration: update experimental external principals API with auth service #7566
Conversation
Isan-Rivkin
changed the title
Isan-Rivkin
added
the
exclude-changelog
E2E Test Results - DynamoDB Local - Local Block Adapter |
api/swagger.yml
Outdated
There was a problem hiding this comment.
assets/something../swagger which is a copy of this one, should be updated too (happens automatically when you run build locally)
There was a problem hiding this comment.
it was just WIP, its added now
|
♻️ PR Preview 05e4840 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
Isan-Rivkin
added
include-changelog
Isan-Rivkin
changed the title
| @@ -1133,14 +1133,14 @@ paths: | |||
| default: | |||
| $ref: "#/components/responses/ServerError" | |||
|
|
|||
| /auth/users/{userId}/external/principals/{principalId}: | |||
| /auth/users/{userId}/external/principals: | |||
There was a problem hiding this comment.
I think userID should also be in the query
It will be less painful in case we decide we don't really want to attach principal to users
There was a problem hiding this comment.
Why? it operates on a user resource, a different functionality would require a new endpoint.
The only reason removing the principalId is due to limitation of the swagger.
This pattern is similar to our GetObject / UploadObject / ListObjects API's.
api/authorization.yml
Outdated
| default: | ||
| $ref: "#/components/responses/ServerError" | ||
|
|
||
|
|
||
| /auth/external/principals: |
There was a problem hiding this comment.
redundancy 😉 (removed now)
Closes #7564