Fix lakectl branch protection set 400 response #7590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E2E Test Results - DynamoDB Local - Local Block Adapter |
itaiad200
force-pushed
the
7589-lakectl-brnch-ptcn-bug
branch
4 times, most recently
from
72d9175 to
ad4adda
Compare
itaiad200
force-pushed
the
7589-lakectl-brnch-ptcn-bug
branch
from
ad4adda to
b3f8a61
Compare
itaiad200
added
the
include-changelog
N-o-Z
approved these changes
Mar 24, 2024
esti/lakectl_test.go
Outdated
| "STORAGE": storage, | ||
| "BRANCH": mainBranch, | ||
| } | ||
| r := strings.NewReplacer("{lakectl}", Lakectl(), "{repo}", repoName, "{storage}", storage, "{branch}", "main") |
There was a problem hiding this comment.
Can we be consistent with how we create the lakectl command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7589