Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new branching model page #762

Merged
merged 10 commits into from
Oct 5, 2020
Merged

new branching model page #762

merged 10 commits into from
Oct 5, 2020

Conversation

YaelRiv
Copy link
Contributor

@YaelRiv YaelRiv commented Oct 4, 2020

Added a new branching model page based on the new use-cases defined.

This is in addition to the reccomondation page we currently have and might replace completely.

We still need to add code snippets tto the relavnt sections.

Added a new branching model page based on the new use-cases defined.

This is in addition to the reccomondation page we currently have and might replace completely.

We still need to add code snippets tto the relavnt sections.
@YaelRiv YaelRiv requested a review from nopcoder October 4, 2020 17:01
Copy link
Contributor

@nopcoder nopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments - used an app - I'm not that good ;)

docs/branching/new_branching_models.md Outdated Show resolved Hide resolved
docs/branching/new_branching_models.md Outdated Show resolved Hide resolved
docs/branching/new_branching_models.md Outdated Show resolved Hide resolved
docs/branching/new_branching_models.md Outdated Show resolved Hide resolved
docs/branching/new_branching_models.md Outdated Show resolved Hide resolved
docs/branching/new_branching_models.md Outdated Show resolved Hide resolved
docs/branching/new_branching_models.md Outdated Show resolved Hide resolved
docs/branching/new_branching_models.md Outdated Show resolved Hide resolved
docs/branching/new_branching_models.md Outdated Show resolved Hide resolved
@nopcoder
Copy link
Contributor

nopcoder commented Oct 4, 2020

General note - I maybe missed some whitespace issues - there are a couple of places that use two spaces instead of one.

YaelRiv and others added 9 commits October 4, 2020 20:22
Co-authored-by: Barak Amar <barak.amar@treeverse.io>
Co-authored-by: Barak Amar <barak.amar@treeverse.io>
Co-authored-by: Barak Amar <barak.amar@treeverse.io>
Co-authored-by: Barak Amar <barak.amar@treeverse.io>
Co-authored-by: Barak Amar <barak.amar@treeverse.io>
Co-authored-by: Barak Amar <barak.amar@treeverse.io>
Co-authored-by: Barak Amar <barak.amar@treeverse.io>
Co-authored-by: Barak Amar <barak.amar@treeverse.io>
Co-authored-by: Barak Amar <barak.amar@treeverse.io>
@YaelRiv
Copy link
Contributor Author

YaelRiv commented Oct 4, 2020

Thank you! Made the changes to the blog post as well.

@YaelRiv YaelRiv merged commit fe608de into master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants