Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lakeFSFS: IAM Role Support Login call #7659

Merged
merged 9 commits into from
Apr 14, 2024
Merged

lakeFSFS: IAM Role Support Login call #7659

merged 9 commits into from
Apr 14, 2024

Conversation

Isan-Rivkin
Copy link
Contributor

@Isan-Rivkin Isan-Rivkin commented Apr 11, 2024 •
edited
Loading

Closes #7658
Docs in a separate PR #7656 (WIP)

@Isan-Rivkin Isan-Rivkin self-assigned this Apr 11, 2024
@Isan-Rivkin Isan-Rivkin added the include-changelog PR description should be included in next release changelog label Apr 11, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 11, 2024 •
edited
Loading

🎊 PR Preview 30e6b63 has been successfully built and deployed to https://treeverse-lakeFS-preview-pr-7659.surge.sh

🕐 Build time: 0.012s

🤖 By surge-preview

@github-actions GitHub Actions
Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

@Isan-Rivkin Isan-Rivkin requested a review from arielshaqed April 11, 2024 15:56
@Isan-Rivkin
Copy link
Contributor Author

Hey @arielshaqed , docs in a separate PR (WIP #7656)

arielshaqed
arielshaqed approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
How are we going to test this on a real lakeFS server? We need to integrate it properly.

clients/hadoopfs/src/main/java/io/lakefs/auth/AWSLakeFSTokenProvider.java Outdated
// build lakeFS login request
ExternalLoginInformation req = new ExternalLoginInformation();

if (this.lakeFSTokenTTLSeconds.isPresent()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use this to apply an operator directly if present.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@Isan-Rivkin
Copy link
Contributor Author

Isan-Rivkin commented Apr 12, 2024 •
edited
Loading

@arielshaqed regarding integration testing, as of right now Iv'e been doing a lot of manuall testing with lakeFS / pyspark / fluffy.
The challenge with proper integration test is that we need fluffy here, so I'll defer this into another issue on enterprise side.

@Isan-Rivkin Isan-Rivkin merged commit 8760e0b into master Apr 14, 2024
35 checks passed
@Isan-Rivkin Isan-Rivkin deleted the feature/lakefsfs-iam-role branch April 14, 2024 06:16
emulatorchen pushed a commit to emulatorchen/lakeFS that referenced this pull request May 27, 2024
@Isan-Rivkin
lakeFSFS: IAM Role Support Login call (treeverse#7659)
c7304b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielshaqed arielshaqed arielshaqed approved these changes

Assignees

@Isan-Rivkin Isan-Rivkin

Labels
include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lakeFSFS: IAM Role Support Login call
2 participants
@Isan-Rivkin @arielshaqed