Python SDK: Support multiple pydantic versions #7672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-o-Z
added
the
include-changelog
E2E Test Results - DynamoDB Local - Local Block Adapter |
itaiad200
reviewed
Apr 15, 2024
clients/python/scripts/pydantic.sh
Outdated
Comment on lines
6
to
14
| echo "... $line ..." | ||
| modules=$(echo $line | awk -F 'from pydantic import ' '{print $2}') | ||
| echo $line | ||
|
|
||
| newline="try:\n from pydantic.v1 import $modules\nexcept ImportError:\n from pydantic import $modules" | ||
|
|
||
| echo "$newline" | ||
|
|
||
| echo "Replacing import statement" |
There was a problem hiding this comment.
I think all the echos are great for debugging but kind of redundant, maybe just output the file
There was a problem hiding this comment.
This is not printed during the build process. It is used when running the script manually for testing
arielshaqed
approved these changes
Apr 15, 2024
arielshaqed
reviewed
Apr 15, 2024
Co-authored-by: Ariel Shaqed (Scolnicov) <ariels@treeverse.io>
ozkatz
approved these changes
Apr 15, 2024
So, I thought about doing it in a separate PR but since you asked. I created a matrix for the wrapper unit tests workflow. |
…upport-multiple-pydantic-versions-6903
emulatorchen
pushed a commit
to emulatorchen/lakeFS
that referenced
this pull request
May 27, 2024
* Python SDK: Support multiple pydantic versions * Fix templates * Update clients/python/scripts/pydantic.sh Co-authored-by: Ariel Shaqed (Scolnicov) <ariels@treeverse.io> * Add unit test flavor with pydantic V1 * Fix script * Fix workflow --------- Co-authored-by: Ariel Shaqed (Scolnicov) <ariels@treeverse.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6903
Change Description
Background
Support pydantic v1/2 on python SDK and HL SDK.
New Feature
We use templates to untag the pydantic version together with a post processing script which changes all imports to try and use the pydantic.v1 compatible module (in pydantic v2) and fallback on pydantic v1 modules
Testing Details
Tested on HL SDK integration tests with pydantic v2 installed
Breaking Change?
No