Wrap all up/down DB migration scripts in a transaction #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents half-successful migration scripts from leaving the DB in an unusable state. Bad migration scripts (e.g. missing DDL removal in a down script) may still break things and require manual fixing. To fix that we would need to use the single-command `CREATE TABLE` form with `FOREIGN KEY`s and `CONSTRAINT`s. We initially made an undocumented decision not to do so, and this commit continues that tradition.
arielshaqed
added
the
pr/merge-if-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents half-successful migration scripts from leaving the DB in an unusable state.
Bad migration scripts (e.g. missing DDL removal in a down script) may still break things and
require manual fixing. To fix that we would need to use the single-command
CREATE TABLEformwith
FOREIGN KEYs andCONSTRAINTs. We initially made an undocumented decision not to do so,and this commit continues that tradition.