Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/import tool progress indication #804

Merged
merged 7 commits into from
Oct 13, 2020

Conversation

johnnyaug
Copy link
Contributor

@johnnyaug johnnyaug commented Oct 12, 2020

Closes #798

@johnnyaug johnnyaug requested a review from nopcoder October 12, 2020 16:28
@codecov-io
Copy link

codecov-io commented Oct 12, 2020

Codecov Report

Merging #804 into master will increase coverage by 0.01%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #804      +/-   ##
==========================================
+ Coverage   41.88%   41.89%   +0.01%     
==========================================
  Files         133      133              
  Lines       10422    10435      +13     
==========================================
+ Hits         4365     4372       +7     
- Misses       5477     5482       +5     
- Partials      580      581       +1     
Impacted Files Coverage Δ
onboard/import.go 62.74% <0.00%> (-2.57%) ⬇️
onboard/catalog_actions.go 67.85% <45.45%> (-2.28%) ⬇️
block/s3/inventory_iterator.go 85.50% <100.00%> (+0.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58ab9d1...27b4239. Read the comment docs.

Comment on lines 37 to 38
current *int64
total *int64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think that it will be better to have these as int64 and when we call the atomic increment get the address of the variable - so we will not be required to handle nil.

Copy link
Contributor

@nopcoder nopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

related to the previous talk about this code -

The doc about why you need to use atomic load when you use atomic API - https://preshing.com/20130618/atomic-vs-non-atomic-operations/

@johnnyaug johnnyaug requested a review from nopcoder October 13, 2020 09:11
Copy link
Contributor

@nopcoder nopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@johnnyaug johnnyaug merged commit dbba26a into master Oct 13, 2020
@johnnyaug johnnyaug deleted the improvement/import_tool_progress_indication branch October 13, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import manifest progress indication
3 participants