add export action and action manager #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and action manager draft
add tests for delete and touch
arielshaqed
reviewed
Oct 13, 2020
Co-authored-by: arielshaqed <ariels@treeverse.io>
Co-authored-by: arielshaqed <ariels@treeverse.io>
document action_manager add data to logs
arielshaqed
approved these changes
Oct 18, 2020
| Workers int // number of goroutines handling tasks | ||
| ChannelSize int // size of the channel containing tasks for workers | ||
| MaxTasks int // max tasks requested in every ownTasks request | ||
| WaitTime *time.Duration // time to wait if OwnTasks returned no tasks. |
There was a problem hiding this comment.
Not sure why these are pointers and the ints are values, identified by being zero.
There was a problem hiding this comment.
@arielshaqed Because 0 is a valid argument for the pointers.
And I didn't wan't to override it with a default value.
parade/action_manager.go
Outdated
| ownedTasks, err := a.parade.OwnTasks(a.handler.Actor(), a.properties.MaxTasks, a.handler.Actions(), a.properties.MaxDuration) | ||
| if err != nil { | ||
| logging.Default().WithField("actor", a.handler.Actor()).Errorf("manager failed to receive tasks: %s", err) | ||
| time.Sleep(*a.properties.WaitTime) |
There was a problem hiding this comment.
Suggested change
| time.Sleep(*a.properties.WaitTime) | |
| time.Sleep(*a.properties.ErrWaitTime) | |
| continue |
?
The first line is in order to wait the time I think you meant. The second line is in order not to wait WaitTime after waiting ErrWaitTime.
| res := a.handler.Handle(task.Action, task.Body) | ||
| err := a.parade.ReturnTask(task.ID, task.Token, res.Status, res.StatusCode) | ||
| if err != nil { | ||
| logging.Default().WithFields(logging.Fields{ |
There was a problem hiding this comment.
Can we maybe add these fields to a logger and use that on all the handlers?
(Something to consider, certainly not in any way required for this PR!)
Co-authored-by: arielshaqed <ariels@treeverse.io>
document actor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
draft