Add update object metadata API #8253
Conversation
Hidden - this is an experimental feature.
|
♻️ PR Preview 9a17670 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
arielshaqed
added
area/cataloger
E2E Test Results - DynamoDB Local - Local Block Adapter |
E2E Test Results - Quickstart |
| schema: | ||
| $ref: "#/components/schemas/UpdateObjectUserMetadata" | ||
| responses: | ||
| 201: |
There was a problem hiding this comment.
Is 201 Created customary for a PUT that updates an existing resource? (not asking that you'd change it, legitimately asking!)
There was a problem hiding this comment.
MDN says we're good:
If the target resource does have a current representation and that representation is successfully modified with the state in the request, the origin server must send either a 200 OK or a 204 No Content to indicate successful completion of the request
Here we're always on the modification flow, you cannot PUT this is the object doesn't exist.
|
|
||
| var errExpectedKV = errors.New("expected <key>=<value>") | ||
|
|
||
| var fsUpdateUserMetadataCmd = &cobra.Command{ |
There was a problem hiding this comment.
Easiest way to develop the code:-)
There was a problem hiding this comment.
Thanks!
@N-o-Z ... can you review or should I get someone else on this?
| schema: | ||
| $ref: "#/components/schemas/UpdateObjectUserMetadata" | ||
| responses: | ||
| 201: |
There was a problem hiding this comment.
MDN says we're good:
If the target resource does have a current representation and that representation is successfully modified with the state in the request, the origin server must send either a 200 OK or a 204 No Content to indicate successful completion of the request
Here we're always on the modification flow, you cannot PUT this is the object doesn't exist.
|
|
||
| var errExpectedKV = errors.New("expected <key>=<value>") | ||
|
|
||
| var fsUpdateUserMetadataCmd = &cobra.Command{ |
There was a problem hiding this comment.
Easiest way to develop the code:-)
api/swagger.yml
Outdated
| - objects | ||
| - experimental | ||
| operationId: updateObjectUserMetadata | ||
| summary: update object metadata |
There was a problem hiding this comment.
Maybe we should mention this will override the current metadata
api/swagger.yml
Outdated
| - objects | ||
| - experimental | ||
| operationId: updateObjectUserMetadata | ||
| summary: update object metadata |
This is an experimental feature. When reviewing please comment about its usability, but focus mainly on correctness.
The code in the controller re-uses an existing physical address, which is supposedly a no-no. However this case is fine: the physical address is used by the same object being updated. So the only way for UGC to remove it would be to lose these races:
Thread 3 is UGC so it only cleans up objects that were abandoned several hours ago. Our UGC model allows us to lose the object in this (extreme) case - this is not a new lossage.
Fixes #8251.