Fix Sample Data checkbox of the Repository Create form #8255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itaigilo
added
area/UI
guy-har
approved these changes
Oct 1, 2024
E2E Test Results - Quickstart |
E2E Test Results - DynamoDB Local - Local Block Adapter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix
In the
Create Repositoryform, marking theUse sample datacheckbox first and updating the Repo name afterwards is clearing the checkbox (so the user that wanted to create a repo with sample data might create it without).This change simplifies the code, making the whole state of the checkbox local to
RepositoryCreateForm.Testing Details
Tested manually.