Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command to check current user in lakectl #8322

Merged

Conversation

ItamarYuran
Copy link
Contributor

Closes #8313

Change Description

Added functionality to check the user currently configured in lakectl

Background

see #8313

New Feature

The new command prints the user info. The info consists of user id, email (only in case exists) and user creation date

Testing Details

Added tests esti tests to check both cases of existing and non existing email

Additional info

Screenshot 2024-10-30 at 11 57 00

@ItamarYuran ItamarYuran added the include-changelog PR description should be included in next release changelog label Oct 30, 2024
@ItamarYuran ItamarYuran linked an issue Oct 30, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Oct 30, 2024

♻️ PR Preview 0ba8d31 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@ItamarYuran ItamarYuran marked this pull request as draft October 30, 2024 10:02
Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

Copy link

github-actions bot commented Oct 30, 2024

E2E Test Results - Quickstart

11 passed

@ItamarYuran ItamarYuran marked this pull request as ready for review October 30, 2024 13:43
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!Thanks!

@@ -0,0 +1,3 @@
User ID: esti
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this file too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, only in case we solve the esti email issue. We could add it when that happens

Copy link
Contributor

@talSofer talSofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A cool improvement! thank you!

@ItamarYuran ItamarYuran merged commit 79b2f4d into master Oct 31, 2024
39 checks passed
@ItamarYuran ItamarYuran deleted the 8313-there-is-no-lakectl-command-to-check-current-user branch October 31, 2024 16:16
@ItamarYuran ItamarYuran restored the 8313-there-is-no-lakectl-command-to-check-current-user branch November 3, 2024 14:24
@N-o-Z
Copy link
Member

N-o-Z commented Nov 3, 2024

@ItamarYuran @arielshaqed why is this a top level command? Why not put it under auth?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include-changelog PR description should be included in next release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is no lakectl command to check current user
4 participants