Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new ReadConfigAction auth action for reading config #837

Merged
merged 3 commits into from
Oct 20, 2020

Conversation

daniel-shuy
Copy link
Contributor

This PR creates ReadConfigAction, a new auth action for reading config, instead of ListRepositoriesAction.

Closes #764

@daniel-shuy daniel-shuy force-pushed the feature/read-config-action branch from e0324ff to 1c755aa Compare October 20, 2020 08:26
@arielshaqed arielshaqed requested a review from ozkatz October 20, 2020 09:02
Copy link
Collaborator

@ozkatz ozkatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this - PR looks great!
Just a couple of small things that I think are missing:

  1. documentation under docs/reference/authorization.md (there's a table listing all available permission actions that needs to be updated)
  2. under auth/setup.go - the built-in "Admins" group should probably come with the appropriate policy that allows to perform this action

@daniel-shuy
Copy link
Contributor Author

documentation under docs/reference/authorization.md (there's a table listing all available permission actions that needs to be updated)

Done!

under auth/setup.go - the built-in "Admins" group should probably come with the appropriate policy that allows to perform this action

AuthFullAccess already imports all auth actions (auth:*)

@daniel-shuy daniel-shuy requested a review from ozkatz October 20, 2020 10:34
Copy link
Collaborator

@ozkatz ozkatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🥳

@ozkatz ozkatz merged commit 8527b2a into treeverse:master Oct 20, 2020
@daniel-shuy daniel-shuy deleted the feature/read-config-action branch October 23, 2020 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new auth action for reading config
2 participants