Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Red Hat OpenShift AI Integration doc #8429

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Added Red Hat OpenShift AI Integration doc #8429

merged 3 commits into from
Dec 19, 2024

Conversation

kesarwam
Copy link
Contributor

No description provided.

@kesarwam kesarwam added docs Improvements or additions to documentation exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached labels Dec 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 17, 2024 •
edited
Loading

♻️ PR Preview 8c76ad8 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@kesarwam kesarwam requested review from iddoavn and ozkatz December 17, 2024 22:06
@github-actions GitHub Actions
Copy link

E2E Test Results - Quickstart

11 passed

@github-actions GitHub Actions
Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

ozkatz
ozkatz requested changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@ozkatz ozkatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Only thing blocking is the broken links to the samples repo

docs/integrations/red_hat_openshift_ai.md Outdated Show resolved Hide resolved
@kesarwam
Copy link
Contributor Author

@ozkatz Fixed broken links.

iddoavn
iddoavn approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@iddoavn iddoavn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broken links in sample repo and docs are fixed now.

@iddoavn iddoavn requested a review from ozkatz December 19, 2024 20:54
@ozkatz ozkatz merged commit b55d450 into master Dec 19, 2024
39 checks passed
@ozkatz ozkatz deleted the docs/integration-red-hat-openshift-ai branch December 19, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iddoavn iddoavn iddoavn approved these changes

@ozkatz ozkatz Awaiting requested review from ozkatz

Assignees
No one assigned
Labels
docs Improvements or additions to documentation exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kesarwam @ozkatz @iddoavn