Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move catalog errors definition into errors file #847

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Conversation

nopcoder
Copy link
Contributor

No description provided.

@nopcoder nopcoder requested a review from guy-har October 20, 2020 11:08
@nopcoder nopcoder self-assigned this Oct 20, 2020
@codecov-io
Copy link

Codecov Report

Merging #847 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #847      +/-   ##
==========================================
+ Coverage   44.21%   44.23%   +0.01%     
==========================================
  Files         137      137              
  Lines       10519    10519              
==========================================
+ Hits         4651     4653       +2     
+ Misses       5266     5265       -1     
+ Partials      602      601       -1     
Impacted Files Coverage Δ
catalog/cataloger_diff.go 66.66% <ø> (ø)
catalog/validate.go 94.44% <ø> (ø)
catalog/cataloger_create_repository.go 65.38% <0.00%> (ø)
catalog/cataloger_create_branch.go 88.67% <0.00%> (+3.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a2a8d5...1432dd2. Read the comment docs.

@nopcoder nopcoder merged commit 3021a8a into master Oct 20, 2020
@nopcoder nopcoder deleted the chore/catalog-err branch October 20, 2020 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants