fix(docs): small grammar fixes & not correct words #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielshaqed
reviewed
Oct 21, 2020
docs/reference/authorization.md
Outdated
| @@ -47,7 +47,7 @@ See [this example for authenticating with the AWS CLI](../using/aws_cli.md). | |||
|
|
|||
| Access to resources is managed very much like [AWS IAM](https://docs.aws.amazon.com/IAM/latest/UserGuide/intro-structure.html){:target="_blank"}. | |||
|
|
|||
| There are 4 basic components to the system: | |||
| There are 4 basic components of the system: | |||
There was a problem hiding this comment.
Please revert this change, "to" is correct here and is common. In this sentence "of" would imply that there can be other components.
docs/reference/import.md
Outdated
| @@ -27,7 +27,7 @@ Unfortunately, copying data is not always feasible for the following reasons: | |||
| 3. It requires you to switch to using the lakeFS endpoint in all places at once. | |||
|
|
|||
| ## Using lakeFS import tool | |||
| To solve this, we offer an import tool which will not copy any data and allow for a more gradual onboarding process. | |||
| To solve this, we offer an import tool that will not copy any data and allow for a more gradual onboarding process. | |||
There was a problem hiding this comment.
Nice. Mind trying this?
Suggested change
| To solve this, we offer an import tool that will not copy any data and allow for a more gradual onboarding process. | |
| To solve this we offer an import tool that does not copy any data, allowing for a more gradual onboarding process. |
There was a problem hiding this comment.
Yeah, I think we can use that.
Thanks for the suggestion!
arielshaqed
approved these changes
Oct 21, 2020
|
Waiting for tests (which should anyway pass...) to pull. |
Codecov Report
@@ Coverage Diff @@
## master #854 +/- ##
==========================================
+ Coverage 44.80% 44.82% +0.01%
==========================================
Files 139 139
Lines 10754 10754
==========================================
+ Hits 4818 4820 +2
+ Misses 5312 5311 -1
+ Partials 624 623 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bunch of small grammar fixes, which were found during the docs learning and researching