Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cataloger mvcc implementation under a different package #946

Merged
merged 9 commits into from
Nov 23, 2020

Conversation

nopcoder
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 22, 2020

Codecov Report

Merging #946 (f3efa47) into master (95e2125) will increase coverage by 0.30%.
The diff coverage is 73.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #946      +/-   ##
==========================================
+ Coverage   44.19%   44.50%   +0.30%     
==========================================
  Files         143      142       -1     
  Lines       11451    11430      -21     
==========================================
+ Hits         5061     5087      +26     
+ Misses       5770     5708      -62     
- Partials      620      635      +15     
Impacted Files Coverage Δ
catalog/mvcc/cache.go 11.11% <0.00%> (ø)
catalog/mvcc/cataloger_create_entry.go 94.73% <ø> (ø)
catalog/mvcc/cataloger_create_multipart_upload.go 100.00% <ø> (ø)
catalog/mvcc/cataloger_get_branch_reference.go 78.94% <0.00%> (ø)
catalog/mvcc/cataloger_is_branch_exists.go 0.00% <ø> (ø)
catalog/mvcc/cataloger_reset_branch.go 66.66% <ø> (ø)
catalog/mvcc/cataloger_reset_entries.go 84.61% <ø> (ø)
catalog/mvcc/cataloger_rollback_commit.go 0.00% <0.00%> (ø)
catalog/mvcc/db_branch_scanner.go 87.36% <ø> (ø)
catalog/mvcc/db_lineage_scanner.go 81.03% <ø> (ø)
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95e2125...f3efa47. Read the comment docs.

Copy link
Contributor

@guy-har guy-har left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@nopcoder nopcoder merged commit 5cea104 into master Nov 23, 2020
@nopcoder nopcoder deleted the chore/mvcc-catalog branch November 23, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants