make postgres connection string optional #948
Conversation
db/migration.go
Outdated
| m, err := migrate.NewWithSourceInstance("httpfs", src, params.ConnectionString) | ||
| var m *migrate.Migrate | ||
| if params.ConnectionString == "" { | ||
| m, err = getMigrateUsingEnvVariables(src) |
There was a problem hiding this comment.
(Trying to learn migrate...) This ends up calling NewWithInstance, the other branch calls NewWithSourceInstance. Can't we do the same in both and have a smaller getMigrateUsingEnvVariables?
[Not in this PR, of course...] |
Codecov Report
@@ Coverage Diff @@
## master #948 +/- ##
==========================================
- Coverage 44.44% 44.43% -0.02%
==========================================
Files 143 143
Lines 11486 11487 +1
==========================================
- Hits 5105 5104 -1
- Misses 5744 5746 +2
Partials 637 637
Continue to review full report at Codecov.
|
db/migration.go
Outdated
| @@ -107,7 +105,9 @@ func getMigrate(params params.Database) (*migrate.Migrate, error) { | |||
| defer func() { | |||
| _ = src.Close() | |||
| }() | |||
|
|
|||
| if params.ConnectionString == "" { | |||
There was a problem hiding this comment.
can you do this one on a temp var so we will not modify the caller data
No description provided.