Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create cataloger based on configuration #951

Merged
merged 5 commits into from
Nov 24, 2020
Merged

Conversation

nopcoder
Copy link
Contributor

No description provided.

@nopcoder nopcoder requested a review from guy-har November 24, 2020 07:26
@nopcoder nopcoder self-assigned this Nov 24, 2020
@nopcoder nopcoder marked this pull request as draft November 24, 2020 07:28
@nopcoder nopcoder marked this pull request as ready for review November 24, 2020 12:51
@codecov-io
Copy link

codecov-io commented Nov 24, 2020

Codecov Report

Merging #951 (2de150b) into master (6f8a0fe) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #951      +/-   ##
==========================================
- Coverage   44.88%   44.82%   -0.06%     
==========================================
  Files         142      142              
  Lines       11447    11448       +1     
==========================================
- Hits         5138     5132       -6     
- Misses       5670     5675       +5     
- Partials      639      641       +2     
Impacted Files Coverage Δ
config/config.go 33.10% <0.00%> (-0.23%) ⬇️
catalog/mvcc/cataloger_create_entry.go 94.73% <0.00%> (-5.27%) ⬇️
catalog/mvcc/cataloger_create_repository.go 59.25% <0.00%> (-3.71%) ⬇️
stats/collector.go 59.77% <0.00%> (-2.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f8a0fe...2de150b. Read the comment docs.

@nopcoder nopcoder merged commit 4c888fa into master Nov 24, 2020
@nopcoder nopcoder deleted the chore/catalog-factory branch November 24, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants