[bugfix] return ErrNotFound correctly #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielshaqed
added
pr/merge-if-approved
|
I think this bug can be seen in various places, where the pgx error may become visible instead of a nice readable error. |
arielshaqed
force-pushed
the
bugfix/not-found
branch
from
962fc6e to
1bc0b69
Compare
Codecov Report
@@ Coverage Diff @@
## master #952 +/- ##
==========================================
- Coverage 44.45% 44.43% -0.02%
==========================================
Files 142 142
Lines 11441 11441
==========================================
- Hits 5086 5084 -2
- Misses 5725 5726 +1
- Partials 630 631 +1
Continue to review full report at Codecov.
|
Package `scany` depends on a different version of `pgx` than the rest of lakeFS. So `errors.Is(err, pgx.ErrNoRows)` fails. Luckily it (sort-of) knows of this issue and wraps this call inside it as `pgxscan.NotFound`. Also make `ErrNotFound` wrap `pgx.ErrNoRows` rather than a new error.
arielshaqed
force-pushed
the
bugfix/not-found
branch
from
1bc0b69 to
dfeba0f
Compare
|
Not quite right :-( @nopcoder please hold off from reviewing for now. |
nopcoder
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package
scanydepends on a different version ofpgxthan the rest of lakeFS. Soerrors.Is(err, pgx.ErrNoRows)fails. Luckily it (sort-of) knows of this issue andwraps this call inside it as
pgxscan.NotFound.Also make
ErrNotFoundwrappgx.ErrNoRowsrather than a new error.