Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration validate version should not create schema_migration table on check #953

Merged
merged 2 commits into from
Nov 24, 2020

Conversation

nopcoder
Copy link
Contributor

No description provided.

- skip table creation on validate migrate version
@nopcoder nopcoder requested a review from guy-har November 24, 2020 09:52
@nopcoder nopcoder self-assigned this Nov 24, 2020
@codecov-io
Copy link

codecov-io commented Nov 24, 2020

Codecov Report

Merging #953 (272da00) into master (5cea104) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #953      +/-   ##
==========================================
- Coverage   44.45%   44.36%   -0.10%     
==========================================
  Files         142      142              
  Lines       11441    11447       +6     
==========================================
- Hits         5086     5078       -8     
- Misses       5725     5735      +10     
- Partials      630      634       +4     
Impacted Files Coverage Δ
db/migration.go 0.00% <0.00%> (ø)
catalog/mvcc/cataloger_commit.go 76.81% <0.00%> (-5.80%) ⬇️
catalog/mvcc/cataloger_create_entry.go 94.73% <0.00%> (-5.27%) ⬇️
catalog/mvcc/cataloger_create_repository.go 59.25% <0.00%> (-3.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cea104...272da00. Read the comment docs.

@nopcoder nopcoder merged commit 6f8a0fe into master Nov 24, 2020
@nopcoder nopcoder deleted the fix/validate-schema branch November 24, 2020 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants