Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename lakefs init to setup and keep init as alias #961

Merged
merged 2 commits into from
Nov 25, 2020
Merged

rename lakefs init to setup and keep init as alias #961

merged 2 commits into from
Nov 25, 2020

Conversation

nopcoder
Copy link
Contributor

Closes #468

@nopcoder nopcoder requested a review from johnnyaug November 24, 2020 17:38
@nopcoder nopcoder assigned nopcoder and unassigned johnnyaug Nov 24, 2020
@codecov-io
Copy link

codecov-io commented Nov 24, 2020 •
edited
Loading

Codecov Report

Merging #961 (4511204) into master (4c888fa) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #961      +/-   ##
==========================================
- Coverage   44.84%   44.79%   -0.06%     
==========================================
  Files         142      142              
  Lines       11448    11448              
==========================================
- Hits         5134     5128       -6     
- Misses       5673     5679       +6     
  Partials      641      641
Impacted Files Coverage Δ
config/logger.go 64.28% <0.00%> (-10.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c888fa...4511204. Read the comment docs.

@nopcoder nopcoder requested a review from arielshaqed November 24, 2020 17:56
arielshaqed
arielshaqed approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! This is great, I did not know about aliases. Could you also please rename the file, to make it easier to find the command when searching by filename?

@nopcoder
Copy link
Contributor Author

Cool! This is great, I did not know about aliases. Could you also please rename the file, to make it easier to find the command when searching by filename?

I did name it setup, missed another file?

@nopcoder nopcoder merged commit 28e4052 into master Nov 25, 2020
@nopcoder nopcoder deleted the feature/lakefs-init branch November 25, 2020 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnyaug johnnyaug johnnyaug approved these changes

@arielshaqed arielshaqed arielshaqed approved these changes

Assignees

@nopcoder nopcoder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename "lakefs init" to "lakefs setup"
4 participants
@nopcoder @codecov-io @johnnyaug @arielshaqed