Fix - merge direction #955

[shamikakumar]

Implemented #955

[codecov-io]

Codecov Report

Merging #968 (d6d3d88) into master (6c42896) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #968   +/-   ##
=======================================
  Coverage   44.58%   44.58%           
=======================================
  Files         142      142           
  Lines       11547    11547           
=======================================
  Hits         5148     5148           
  Misses       5757     5757           
  Partials      642      642           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c42896...d6d3d88. Read the comment docs.

[itaiad200]

@shamikakumar Thanks for your effort!
Notice the direction of the arrow is opposite to the direction of the merge.
You can switch the arrow direction, however it makes more sense if you could simply switch the labels between the base branch and the target branch. e.g. merge to master should have master on the left, arrow pointing left, and the feature branch on the right.

[itaiad200]

Should switch branches so that merge direction matches.

[shamikakumar]

@itaiad200 oh, my bad. I see now how that's confusing, since we're used to the GitHub convention.

[itaiad200]

Hey @shamikakumar
You're absolutely right about keeping Github's convention!

I still see the merge direction the other way around:

The scenario: created feature-1 branch from master, added a single file to feature-1 branch and committed. When I'm comparing I should get the above results when master is on the left (base branch) and feature-1 branch is on the right. You can also use the description in the Merge button for the direction.

Let me know if you have any further questions, I think we're almost there :)

[shamikakumar]

@itaiad200 could you check now ? I think you may be viewing my previous commit

[itaiad200]

LGTM
Thanks for your help @shamikakumar !