945 sstable interface #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verse/lakeFS into 945-sstable-tree-interfaces
Co-authored-by: itaiad200 <itaiad200@gmail.com>
…e/lakeFS into feature/rocks-catalog-interface
Codecov Report
@@ Coverage Diff @@
## master #969 +/- ##
==========================================
- Coverage 44.58% 44.56% -0.02%
==========================================
Files 142 142
Lines 11547 11547
==========================================
- Hits 5148 5146 -2
- Misses 5757 5758 +1
- Partials 642 643 +1
Continue to review full report at Codecov.
|
tzahij
previously approved these changes
Nov 29, 2020
forest/sstable/sstable.go
Outdated
| GetEntry(path rocks.Path, tid SSTableID) (*rocks.Entry, error) | ||
|
|
||
| // SSTableIterator takes a given SSTable and returns an EntryIterator seeked to >= "from" path | ||
| SSTableIterator(tid SSTableID, from rocks.Path) (rocks.EntryIterator, error) |
There was a problem hiding this comment.
I prefere newSSTableIterator
tzahij
approved these changes
Nov 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.