cataloger rocks initial connect to catalog #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #976 +/- ##
==========================================
- Coverage 44.56% 44.55% -0.01%
==========================================
Files 142 142
Lines 11547 11547
==========================================
- Hits 5146 5145 -1
- Misses 5758 5760 +2
+ Partials 643 642 -1
Continue to review full report at Codecov.
|
guy-har
approved these changes
Nov 29, 2020
catalog/rocks/catalog.go
Outdated
Comment on lines
403
to
405
| if ns == "" { | ||
| return "", ErrInvalidStorageNamespace | ||
| } |
There was a problem hiding this comment.
Is this validation enough?
There was a problem hiding this comment.
never enough - adding some code
catalog/rocks/catalog.go
Outdated
Comment on lines
445
to
447
| func NewCommitID(id string) (CommitID, error) { | ||
| return CommitID(id), nil | ||
| } |
catalog/rocks/catalog.go
Outdated
Comment on lines
424
to
428
| func NewRef(id string) (Ref, error) { | ||
| // TODO(barak): check with git what is a valid ref value | ||
| if !reValidBranchID.MatchString(id) { | ||
| return "", ErrInvalidRef | ||
| } |
There was a problem hiding this comment.
replace branchID verification with git ref verification( ~, ^, etc...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.