Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog rollback to commit branch verification #988

Merged
merged 3 commits into from
Dec 2, 2020

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Dec 2, 2020

Accept and verify the the branch name in the mvcc cataloger.
The new implementation requires branch as the change in position is in on the ref level.

@nopcoder nopcoder requested a review from itaiad200 December 2, 2020 07:52
@nopcoder nopcoder self-assigned this Dec 2, 2020
@codecov-io
Copy link

Codecov Report

Merging #988 (2bbb49b) into master (7b08240) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #988      +/-   ##
==========================================
- Coverage   44.62%   44.60%   -0.03%     
==========================================
  Files         142      142              
  Lines       11585    11587       +2     
==========================================
- Hits         5170     5168       -2     
- Misses       5763     5765       +2     
- Partials      652      654       +2     
Impacted Files Coverage Δ
api/api_controller.go 37.91% <0.00%> (ø)
catalog/mvcc/cataloger_rollback_commit.go 52.63% <0.00%> (-2.93%) ⬇️
catalog/mvcc/cataloger_create_repository.go 59.25% <0.00%> (-3.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b08240...2bbb49b. Read the comment docs.

@nopcoder nopcoder merged commit 83478b7 into master Dec 2, 2020
@nopcoder nopcoder deleted the feature/revert-commit branch December 2, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants