Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract multipart upload implementation from mvcc cataloger #989

Merged
merged 8 commits into from
Dec 2, 2020

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Dec 2, 2020

Extracting multipart upload handling from cataloger as a package under gateway

  • The service is no multiparts.Tracker
  • Removed the use of repository, it will track parts based on tracking ID
  • Postgres table and index 'gateway_multiparts'

@nopcoder nopcoder requested a review from guy-har December 2, 2020 07:50
@nopcoder nopcoder self-assigned this Dec 2, 2020
ddl/000016_gateway_multiparts.up.sql Outdated Show resolved Hide resolved
ddl/000016_gateway_multiparts.down.sql Outdated Show resolved Hide resolved
gateway/handler_test.go Outdated Show resolved Hide resolved
@nopcoder nopcoder requested a review from guy-har December 2, 2020 15:20
Copy link
Contributor

@guy-har guy-har left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great

@codecov-io
Copy link

Codecov Report

Merging #989 (f655cef) into master (4f89db9) will decrease coverage by 0.32%.
The diff coverage is 35.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #989      +/-   ##
==========================================
- Coverage   44.58%   44.26%   -0.33%     
==========================================
  Files         142      140       -2     
  Lines       11547    11570      +23     
==========================================
- Hits         5148     5121      -27     
- Misses       5757     5799      +42     
- Partials      642      650       +8     
Impacted Files Coverage Δ
api/handler.go 70.83% <ø> (ø)
catalog/mvcc/validate.go 88.23% <ø> (-6.21%) ⬇️
gateway/multiparts/tracker.go 0.00% <0.00%> (ø)
gateway/operations/base.go 0.00% <ø> (ø)
gateway/operations/postobject.go 0.00% <0.00%> (ø)
gateway/operations/putobject.go 0.00% <0.00%> (ø)
gateway/handler.go 58.78% <76.47%> (+0.22%) ⬆️
catalog/mvcc/cataloger_create_repository.go 59.25% <0.00%> (-3.71%) ⬇️
stats/collector.go 61.36% <0.00%> (-0.71%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f89db9...f655cef. Read the comment docs.

@nopcoder nopcoder changed the title Extract multipart upload impl from mvcc cataloger Extract multipart upload implementation from mvcc cataloger Dec 2, 2020
@nopcoder nopcoder merged commit a57e068 into master Dec 2, 2020
@nopcoder nopcoder deleted the feature/multipart branch December 2, 2020 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants