Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test committed delete with list #999

Closed
wants to merge 3 commits into from
Closed

Test committed delete with list #999

wants to merge 3 commits into from

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Dec 4, 2020 •
edited
Loading

Test #997

@nopcoder nopcoder self-assigned this Dec 5, 2020
arielshaqed
arielshaqed approved these changes Dec 5, 2020
View reviewed changes
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Also I can see it failing. Let's pull with skip (so test pass), and/or rebase #1000 on top of this

@arielshaqed arielshaqed mentioned this pull request Dec 5, 2020
Merged
@nopcoder nopcoder closed this Dec 5, 2020
@nopcoder nopcoder deleted the chore/del-entry-test branch February 4, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielshaqed arielshaqed arielshaqed approved these changes

Assignees

@nopcoder nopcoder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nopcoder @arielshaqed