Request all missing experiments #1290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 45c8eea and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.2% (0.0% change). View more on Code Climate. |
mattseddon
requested review from
rogermparent and
sroy3
and removed request for
rogermparent
sroy3
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the logic inside the
PlotsModelto always request missing experiment revisions but to leave out checkpoints. Plugs the first bug from #1277:Demo
Screen.Recording.2022-02-04.at.10.04.07.am.mov
Once I have added the tree to select revisions I will revisit this logic so that we never request more than 6 revisions at the one time. My initial thought is that if we can persist the selected revisions between sessions, then check them against the
exp showdata on startup. If there isn't a match then we can dump the preference and have nothing selected as a baseline. Will be easier to work out the behaviour once we have a tree in place.