Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report.json gets generated even when the -o flag isn't specified #1072

Closed
akshatagarwl opened this issue Jun 11, 2021 · 0 comments · Fixed by #1134
Closed

report.json gets generated even when the -o flag isn't specified #1072

akshatagarwl opened this issue Jun 11, 2021 · 0 comments · Fixed by #1134
Labels
bug Something isn't working _complexity:low A task with a low complexity that should be easy to understand _size:small A small task that should be quick to do

Comments

@akshatagarwl
Copy link
Contributor

akshatagarwl commented Jun 11, 2021 •
edited
Loading

Problem
The -o flag for the test subcommand is used to generate a test report to a specified path (default: report.json) but even when this flag isn't passed the report.json still gets generated.

Steps to reproduce

  1. remove any existing report.json that might be present from a previous run
  2. run the any of the tests for eg for unit tests
cargo run --release -- test unit tremor-cli/tests/
@akshatagarwl akshatagarwl added the bug Something isn't working label Jun 11, 2021
@Licenser Licenser added _complexity:low A task with a low complexity that should be easy to understand _size:small A small task that should be quick to do labels Jul 15, 2021
Licenser added a commit that referenced this issue Jul 15, 2021
@Licenser
Don't generate reports when not asked for it, closes #1072
0edb6f1 
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Licenser added a commit that referenced this issue Jul 15, 2021
@Licenser
Don't generate reports when not asked for it, closes #1072
c687436 
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
@Licenser Licenser mentioned this issue Jul 15, 2021
Merged
6 tasks
Licenser added a commit that referenced this issue Jul 15, 2021
@Licenser
Don't generate reports when not asked for it, closes #1072
81a2e3f 
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
@Licenser Licenser mentioned this issue Aug 11, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working _complexity:low A task with a low complexity that should be easy to understand _size:small A small task that should be quick to do
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't generate reports when not asked for it, closes #1072 tremor-rs/tremor-runtime
2 participants
@Licenser @akshatagarwl