Adding code for pubsub connectors #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jigyasak05
requested review from
anupdhml,
darach,
Licenser and
mfelsche
as code owners
Licenser
reviewed
May 13, 2021
Licenser
reviewed
May 13, 2021
Licenser
reviewed
May 13, 2021
Licenser
reviewed
May 13, 2021
Licenser
reviewed
May 13, 2021
Licenser
reviewed
May 13, 2021
Licenser
reviewed
May 13, 2021
Licenser
reviewed
May 13, 2021
Licenser
reviewed
May 13, 2021
Comment on lines
+136
to
+139
| let file; | ||
| match env::var("GOOGLE_APPLICATION_CREDENTIALS") { | ||
| Ok(val) => file = val, | ||
| Err(_e) => file = "service account file not found".to_string(), | ||
| } |
There was a problem hiding this comment.
This could work nicer as:
let file = env::var("GOOGLE_APPLICATION_CREDENTIALS").map_err("service account file not found")?;
jigyasak05
force-pushed
the
pubsub-connector
branch
2 times, most recently
from
f58e538
to
a6608e7
Compare
Signed-off-by: Jigyasa <jigyasakhaneja05@gmail.com>
Signed-off-by: Jigyasa <jigyasakhaneja05@gmail.com>
Signed-off-by: Jigyasa <jigyasakhaneja05@gmail.com>
Signed-off-by: Jigyasa <jigyasakhaneja05@gmail.com>
jigyasak05
force-pushed
the
pubsub-connector
branch
from
a6608e7
to
e1d473a
Compare
Signed-off-by: Jigyasa <jigyasakhaneja05@gmail.com>
Licenser
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jigyasa jigyasakhaneja05@gmail.com
Pull request
Description
Added code for Google Cloud Pubsub connectors
Related
#724
Checklist
Performance