Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pub/Sub modification for message ordering #1067

Merged
merged 2 commits into from
Jun 11, 2021
Merged

Pub/Sub modification for message ordering #1067

merged 2 commits into from
Jun 11, 2021

Conversation

jigyasak05
Copy link
Contributor

Signed-off-by: Jigyasa jigyasakhaneja05@gmail.com

Pull request

Description

Adding support for creating subscription with the option to enable/disable message ordering

Related

#724

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

@coveralls
Copy link
Collaborator

coveralls commented Jun 8, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 83.911% when pulling d9dfd71 on jigyasak05:pubsub-connector into 436623f on tremor-rs:main.

Licenser
Licenser reviewed Jun 8, 2021
View reviewed changes
src/sink/gpub.rs Outdated Show resolved Hide resolved
Licenser
Licenser reviewed Jun 8, 2021
View reviewed changes
src/sink/gpub.rs Outdated Show resolved Hide resolved
@jigyasak05
Copy link
Contributor Author

jigyasak05 commented Jun 8, 2021 •
edited
Loading

I'm not sure why this CI test is failing ;-; How do I fix it? @Licenser

@jigyasak05
Adding support for creating subscription with the option to enable or…
32a585a 
…dering

Signed-off-by: Jigyasa <jigyasakhaneja05@gmail.com>
@jigyasak05
review changes
d9dfd71 
Signed-off-by: Jigyasa <jigyasakhaneja05@gmail.com>
Licenser
Licenser approved these changes Jun 10, 2021
View reviewed changes
Copy link
Member

@Licenser Licenser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you so much, you rock!! 🚀

@darach
Copy link
Member

darach commented Jun 11, 2021

Woop woop!

@darach darach merged commit 3571965 into tremor-rs:main Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Licenser Licenser Licenser approved these changes

@anupdhml anupdhml Awaiting requested review from anupdhml

@darach darach Awaiting requested review from darach darach is a code owner

@mfelsche mfelsche Awaiting requested review from mfelsche mfelsche is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jigyasak05 @coveralls @darach @Licenser