Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add env source #1157

Merged
merged 2 commits into from
Aug 3, 2021
Merged

Add env source #1157

merged 2 commits into from
Aug 3, 2021

Conversation

Licenser
Copy link
Member

@Licenser Licenser commented Jul 30, 2021 •
edited
Loading

Pull request

Description

Add env onramp to read environment variables

Related

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

No hot path code changes

@Licenser
Add env source
ffcfbb0 
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
@coveralls
Copy link
Collaborator

coveralls commented Jul 30, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 84.528% when pulling a3d0236 on env-onramp into ee81082 on main.

@Licenser Licenser enabled auto-merge (rebase) August 2, 2021 09:18
@Licenser Licenser merged commit 5e9296e into main Aug 3, 2021
@Licenser Licenser deleted the env-onramp branch August 3, 2021 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfelsche mfelsche mfelsche approved these changes

@anupdhml anupdhml Awaiting requested review from anupdhml

@darach darach Awaiting requested review from darach darach is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Tremor connector to read environment variables
3 participants
@Licenser @coveralls @mfelsche