tremor test: Run single tests without suite.

[MordecaiMalignatus]

Pull request

Description

Implement the cargo test $PATH_TO_SPECIFIC_TEST functionality for tremor test. That meaning, that a single test can be run, rather than either having to narrow to a single test by tags, or having to run a whole suite when only one result is desired. tremor test bench ./tests/bench/bench_pipe_passthrough only runs that benchmark.

This is currently functional (it runs single tests when specified), but very ugly code that I still need to refactor, and a bunch of the meta work (docs, changelog etc) is not done yet.

Related

Closes #1139.
Docs: tremor-rs/tremor-www#129

Checklist

• The RFC, if required, has been submitted and approved
• Any user-facing impact of the changes is reflected in docs.tremor.rs
• The code is tested
• Use of unsafe code is reasoned about in a comment
• Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
• The performance impact of the change is measured (see below)

Performance

Not applicable, except to speed up single-test runs. No other behaviour is impacted.

[Licenser]

Hi @MordecaiMalignatus awesome thanks! It looks good at a first glance :) but it'll need some clippy love, the expects should become Result's and a DCO signoff is needed :)

[MordecaiMalignatus]

Noted. What’s the DCO signoff for, precisely? Never seen having to sign off on my own commits before :D A question while we’re at it: how much refactoring can I put into this patch? I sorta got carried away fixing stuff to get the line count of `run_cmd` down and making it more readable but I think I might be better off making that a separate, more deliberate patch. I think I might file some follow up patches giving some love to the rest subcommand.

…

On 25. Oct 2021, at 11:54, Heinz N. Gies ***@***.***> wrote:  Hi @MordecaiMalignatus awesome thanks! It looks good at a first glance :) but it'll need some clippy love, the expects should become Result's and a DCO signoff is needed :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[coveralls]

Pull Request Test Coverage Report for Build 1384490644

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 4 unchanged lines in 4 files lost coverage.
• Overall coverage increased (+0.009%) to 87.298%

---

Files with Coverage Reduction	New Missed Lines	%
tremor-script/src/ast/eq.rs	1	68.52%
tremor-script/src/ast.rs	1	75.54%
tremor-script/src/ast/visitors.rs	1	74.75%
tremor-script/src/tilde.rs	1	85.88%

Totals
Change from base Build 1380387893:	0.009%
Covered Lines:	18570
Relevant Lines:	21272

---

💛 - Coveralls

[Licenser]

DCO signoff is basically a way for a contributor to say "Yes I made this contribution and was allowed to do so" it has to do with a bunch of very boring very legal stuff and lighter weight then a CLA (Contributor Agreement) that people would have to sign (yuck)

https://opensource.com/article/18/3/cla-vs-dco-whats-difference and https://en.wikipedia.org/wiki/Developer_Certificate_of_Origin have some resources for details :)

the dco bot explains how to do it after the fact: https://github.com/tremor-rs/tremor-runtime/pull/1283/checks?check_run_id=3987618586

doing it when committing is basically adding -s (s for signoff)

On the freedom - go nuts as long as it comes out better then it went in we're happy :). This is not on the critical path (read: it doesn't block any other work) so there is no reason to keep a PR small ( aside of personal preference ;) )

[MordecaiMalignatus]

Things done:

• Clippy suggestions were applied (I love clippy so very much)
• Signoff added
• Extra refactorings spun out into a future patch, to keep patches small and avoid the "Ah yes several thousand lines diff, LGTM" haze.
• Expects converted into explicit errors

This is done so far from my side. I'd like to give the testing subcommand/subsystem a bit of love after I've gotten a bit more familiar with it, I think I could make some improvement here :)

[MordecaiMalignatus]

I'm not sure how to add automated tests for this patch, it seems rather hard to test. :(

[mfelsche]

We don't have tests yet for stuff like this, so i think it is fine to not add one for this PR.

[darach]

LGTM. Great work! Thank you for your contribution!