Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in tremor-common README.md #2676

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

darach
Copy link
Member

@darach darach commented Oct 23, 2024

Pull request

Description

Small typo in tremor-common README that creates a 404 on crates.io linking to docs.rs

Checklist

  • [ x ] The RFC, if required, has been submitted and approved
  • [ x ] Any user-facing impact of the changes is reflected in docs.tremor.rs
  • [ x ] The code is tested
  • [ x ] Use of unsafe code is reasoned about in a comment
  • [ x ] Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • [ x ] The performance impact of the change is measured (see below)

Performance

No impact

Signed-off-by: Darach Ennis <darach@gmail.com>
@Licenser Licenser force-pushed the small-typo-fix-tremor-common branch from 8df7b18 to 816b2ba Compare October 23, 2024 12:55
@Licenser Licenser enabled auto-merge (rebase) October 23, 2024 12:56
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.34%. Comparing base (9a689fb) to head (816b2ba).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2676      +/-   ##
==========================================
- Coverage   91.34%   91.34%   -0.01%     
==========================================
  Files         309      309              
  Lines       60380    60380              
==========================================
- Hits        55156    55153       -3     
- Misses       5224     5227       +3     
Flag Coverage Δ
e2e-command 11.25% <ø> (ø)
e2e-integration 50.26% <ø> (-0.17%) ⬇️
e2e-unit 12.54% <ø> (ø)
e2etests 52.59% <ø> (-0.17%) ⬇️
tremorapi 14.47% <ø> (ø)
tremorcodec 63.96% <ø> (ø)
tremorcommon 63.04% <ø> (ø)
tremorconnectors 28.74% <ø> (-0.01%) ⬇️
tremorconnectorsaws 11.22% <ø> (ø)
tremorconnectorsazure 4.67% <ø> (ø)
tremorconnectorsgcp 25.31% <ø> (+<0.01%) ⬆️
tremorconnectorsobjectstorage 0.06% <ø> (ø)
tremorconnectorsotel 12.52% <ø> (ø)
tremorconnectorstesthelpers 68.25% <ø> (ø)
tremorinflux 87.71% <ø> (ø)
tremorinterceptor 55.34% <ø> (ø)
tremorpipeline 31.06% <ø> (ø)
tremorruntime 47.12% <ø> (+0.02%) ⬆️
tremorscript 54.90% <ø> (ø)
tremorsystem 5.76% <ø> (ø)
tremorvalue 69.49% <ø> (-0.07%) ⬇️
unittests 89.21% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a689fb...816b2ba. Read the comment docs.

@Licenser Licenser merged commit dc2db3a into tremor-rs:main Oct 23, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants