Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI / CI fixes #580

Merged
merged 4 commits into from
Nov 11, 2020
Merged

CLI / CI fixes #580

merged 4 commits into from
Nov 11, 2020

Conversation

Licenser
Copy link
Member

Pull request

Description

  • Allow -i on tests to run only a subset of tests.
  • Fix failure reporting for command tests

Related

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment

@Licenser
Fix #579 -i allows selecting a subset now
7618bf2 
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
darach
darach previously approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@darach darach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 11, 2020 •
edited
Loading

Codecov Report

Merging #580 (61d8730) into main (0284cbe) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #580   +/-   ##
=======================================
  Coverage   80.51%   80.51%           
=======================================
  Files         101      101           
  Lines       13868    13868           
=======================================
  Hits        11166    11166           
  Misses       2702     2702

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d9f478...d80b4bb. Read the comment docs.

@Licenser
Fix error reporting on test failures
75d8491 
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
@Licenser Licenser marked this pull request as ready for review November 11, 2020 10:53
@Licenser
Obey clippy
aa09d28 
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
@Licenser
Disable failing tests since it's tackled in another PR
d80b4bb 
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
darach
darach approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@darach darach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Licenser Licenser merged commit 9af544c into main Nov 11, 2020
@Licenser Licenser deleted the fix-cli-isues branch November 11, 2020 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darach darach darach approved these changes

@anupdhml anupdhml Awaiting requested review from anupdhml

@mfelsche mfelsche Awaiting requested review from mfelsche mfelsche is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test include / exclude doesn't allow limiting scope CI not reporting coverage
2 participants
@Licenser @darach