-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output more helpful error messages for pipeline runtime errors #629
Conversation
Codecov Report
@@ Coverage Diff @@
## main #629 +/- ##
==========================================
+ Coverage 80.83% 80.89% +0.06%
==========================================
Files 101 101
Lines 14304 14434 +130
==========================================
+ Hits 11562 11676 +114
- Misses 2742 2758 +16
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
9ad288b
to
1e2e3c5
Compare
… float literals. Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Looks like -0.1% Coverage :( |
adding some tests tomorrow morning. |
Let me switch the state to draft so we know it's pre-review :) |
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 and <3 for the coverage increase!
Ehrensache! ❤️ |
All tests pass and codecov status is reported, will merge since codecov is still broken :/ |
Pull request
Description
If we have an error that is locatable within the pipeline source, we are going do display an error message, showing the error within the pipeline source.
Also:
tremor run
.Related
Checklist