Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from memmap to mapr #641

Merged
merged 2 commits into from
Dec 7, 2020
Merged

Move from memmap to mapr #641

merged 2 commits into from
Dec 7, 2020

Conversation

mfelsche
Copy link
Member

@mfelsche mfelsche commented Dec 7, 2020

Pull request

Description

  • Move from memmap to mapr

I decided to go with mapr as it is backed by a github org (filecoin), not a single person and has more recent changes.

  • Fix compatibility between async-std and tokio 0.3 needed for postgres ramps

This was tested by running the workshop examples involving postgres.

Related

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes or other observable changes in behavior

Matthias Wahl added 2 commits December 7, 2020 11:37
Move from memmap to mapr
a454767 
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Fix missing compatibility with tokio 0.3 needed for postgres ramps.
36c861e 
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
darach
darach approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@darach darach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Licenser
Licenser approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@Licenser Licenser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@coveralls
Copy link
Collaborator

coveralls commented Dec 7, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 80.093% when pulling 36c861e on memmap-mapr into f90f276 on main.

@Licenser Licenser merged commit ca3c875 into main Dec 7, 2020
@Licenser Licenser deleted the memmap-mapr branch December 7, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Licenser Licenser Licenser approved these changes

@darach darach darach approved these changes

@anupdhml anupdhml Awaiting requested review from anupdhml

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2020-0077: memmap is unmaintained
4 participants
@mfelsche @coveralls @Licenser @darach