String interpolation new #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Licenser
force-pushed
the
string-interpolation-new
branch
from
133394b to
77ae3a0
Compare
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Licenser
force-pushed
the
string-interpolation-new
branch
from
7f2f835 to
b9a481b
Compare
|
Question that comes to mind is: What error will a string like |
mfelsche
previously approved these changes
Feb 2, 2021
Good question :D and great catch I didn't think about that, will add a test tomorrow! |
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Licenser
force-pushed
the
string-interpolation-new
branch
from
b5e363e to
7a59a06
Compare
|
I added a new (nicer) error for the "#{}" case 👍 good catch @mfelsche ! |
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Licenser
force-pushed
the
string-interpolation-new
branch
from
57be38d to
9982263
Compare
mfelsche
approved these changes
Feb 3, 2021
| @@ -0,0 +1,4 @@ | |||
| Error: | |||
| 1 | "#{}" | |||
| | ^^^ You have an interpolation without content. | |||
| Error: | ||
| 4 | end; | ||
| 5 | | ||
| 6 | boom(1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
This implements the RFC for string interpolation
Related
Checklist