Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure blaster sends all events from the source #759

Merged
merged 2 commits into from
Feb 16, 2021
Merged

Ensure blaster sends all events from the source #759

merged 2 commits into from
Feb 16, 2021

Conversation

anupdhml
Copy link
Contributor

@anupdhml anupdhml commented Feb 16, 2021 •
edited
Loading

Pull request

Ensure that blaster sends all the events from the specified file source.

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes or other observable changes in behavior

@anupdhml
Ensure blaster sends all events from the source
bce4c84 
Signed-off-by: Anup Dhamala <anupdhml+git@gmail.com>
@coveralls
Copy link
Collaborator

coveralls commented Feb 16, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 81.407% when pulling 4128994 on fix-blaster into 2ef3e41 on main.

darach
darach previously approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@darach darach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Licenser
Licenser previously approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@Licenser Licenser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

Add integration tests for blaster
4128994 
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
@mfelsche mfelsche dismissed stale reviews from Licenser and darach via 4128994 February 16, 2021 11:19
@Licenser Licenser self-requested a review February 16, 2021 11:46
@mfelsche mfelsche merged commit a55cfc8 into main Feb 16, 2021
@mfelsche mfelsche deleted the fix-blaster branch February 16, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Licenser Licenser Licenser approved these changes

@darach darach darach left review comments

@mfelsche mfelsche Awaiting requested review from mfelsche mfelsche is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anupdhml @coveralls @Licenser @darach @mfelsche