Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let Docker handle signals #806

Merged
merged 3 commits into from
Mar 3, 2021
Merged

Let Docker handle signals #806

merged 3 commits into from
Mar 3, 2021

Conversation

mfelsche
Copy link
Member

@mfelsche mfelsche commented Mar 3, 2021 •
edited
Loading

Pull request

Description

Enable signals in docker by not running as PID1, but let tini do the work.

We could achieve the same by always using --init on each docker run call, but it is more convenient to do it here for every user.

Related

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

@coveralls
Copy link
Collaborator

coveralls commented Mar 3, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 81.574% when pulling 8ff9b22 on docker-signals into 73349b3 on main.

@mfelsche mfelsche changed the title Let Docker docker handle signals Let Docker handle signals Mar 3, 2021
anupdhml
anupdhml previously approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@anupdhml anupdhml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice addition!

needs rebase, otherwise LGTM!

Matthias Wahl added 3 commits March 3, 2021 21:03
Use tini in docker as PID1 to enable signal handling.
63a6a6e 
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
update release process bits for language server and git tagging.
bb80140 
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Update changelog
8ff9b22 
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
@anupdhml anupdhml merged commit e88ba2e into main Mar 3, 2021
@anupdhml anupdhml deleted the docker-signals branch March 3, 2021 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anupdhml anupdhml anupdhml approved these changes

@darach darach Awaiting requested review from darach darach is a code owner

@Licenser Licenser Awaiting requested review from Licenser Licenser is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Find a way to allow Ctrl-C to stop an interactive dockerized tremor session
3 participants
@mfelsche @coveralls @anupdhml